Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all Filterset to be compliant with Nautobot naming convention #145

Closed
dgarros opened this issue Oct 21, 2021 · 0 comments · Fixed by #146
Closed

Rename all Filterset to be compliant with Nautobot naming convention #145

dgarros opened this issue Oct 21, 2021 · 0 comments · Fixed by #146

Comments

@dgarros
Copy link

dgarros commented Oct 21, 2021

Environment

  • Python version: 3.7
  • Nautobot version: 1.1.3
  • nautobot-golden-config version: develop

Steps to Reproduce

  1. Check the name of the filterset defined in filters.py

Expected Behavior

Following, Nautobot naming convention the filterset should be named <ModelName>FilterSet
it's especially important for GraphQL when we are using @extras_feature because if the name of the filterset is not correct the GraphQL type generated by @extras_feature will miss the filtering options

Extras_feature for GraphQL is leverating the function get_filterset_for_model from nautobot/utilities/utils

Observed Behavior

The filterset are named <ModelName>Filter instead of <ModelName>FilterSet and as a result filtering is not available in GraphQL

Screen Shot 2021-10-21 at 2 21 56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant