Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional Git providers #27

Closed
smk4664 opened this issue Mar 1, 2021 · 3 comments · Fixed by #31
Closed

Support additional Git providers #27

smk4664 opened this issue Mar 1, 2021 · 3 comments · Fixed by #31

Comments

@smk4664
Copy link
Contributor

smk4664 commented Mar 1, 2021

Environment

  • Python version: 3.7.9
  • Nautobot version: v1.0.0b1
  • nautobot-golden-config version: 0.9.0

Due to https://github.com/nautobot/nautobot-plugin-golden-config/blob/09e7277c4d47890beaf0756bf5a58d7b4ef898c9/nautobot_golden_config/utilities/git.py#L25
the url built will only work in Git providers where the token is the username (GitHub). This does not work when the token is the password (Bitbucket or GitLab).

The proposed implementation is to generate the url similar to the url generated by Nautobot: https://github.com/nautobot/nautobot/blob/8868c442c2e263c1072cfc1504b99990cf78c15f/nautobot/extras/datasources/git.py#L124

@991jo
Copy link

991jo commented Mar 9, 2021

since nautobot can handle pulling of repos, would it be usefull to put the push feature into nautobot itself, so that plugins don't have to reinvent the feature and get a generic "push/pull this repo" function from nautobot? This would solve the problem for all kinds of git providers and plugins.

@itdependsnetworks
Copy link
Contributor

I spoke with @glennmatthews about this, I believe we ended up with no... but those were a busy... crazy few weeks so my memory is a bit mush since then :)

@smk4664
Copy link
Contributor Author

smk4664 commented Mar 10, 2021

For now, I am going to create a PR to fix the initial issue, but it might be good to revisit using Nautobot itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants