Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve view coverage in test_views.py #717

Open
glennmatthews opened this issue Feb 8, 2024 · 1 comment
Open

Improve view coverage in test_views.py #717

glennmatthews opened this issue Feb 8, 2024 · 1 comment

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Nautobot version: 2.1.3
  • nautobot-golden-config version: 2.0.1

Proposed Functionality

nautobot/nautobot#5254 caused several GC views to raise exceptions when accessed, however upstream CI testing of this repository remained "green"/passing in full despite this issue. It would be good to implement at least basic sanity tests for all views in this app (inheriting a test for each view from nautobot.apps.testing.ViewTestCases would be a good starting point) in order to more rapidly detect fundamental breakage of the app.

Use Case

More comprehensive testing, earlier detection of fundamental breakage.

@itdependsnetworks
Copy link
Contributor

Would it be ok to track this on cookiecutter? I checked DLM, and it didn't have a contract test as an example, and I suspect this will be the case across many apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants