Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow foreign keys inside of many to many relationships. #377

Merged
merged 1 commit into from Mar 14, 2024

Conversation

Kircheneer
Copy link
Contributor

@Kircheneer Kircheneer commented Mar 5, 2024

Closes #295

@Kircheneer Kircheneer requested a review from a team as a code owner March 5, 2024 15:40
@Kircheneer
Copy link
Contributor Author

@gioccher can you share your coauthor information? I'm trying to credit you for the fix, but @Co-Authored-By: Claudio Beretta <gioccher@users.noreply.github.com> doesn't seem to be working.

@gioccher
Copy link

gioccher commented Mar 5, 2024

@gioccher can you share your coauthor information? I'm trying to credit you for the fix, but @Co-Authored-By: Claudio Beretta <gioccher@users.noreply.github.com> doesn't seem to be working.

oh thanks, but co-authorship is definitely not needed

@Kircheneer Kircheneer self-assigned this Mar 12, 2024
@Kircheneer Kircheneer force-pushed the fix-295 branch 5 times, most recently from 59a3b7e to ae7f9f1 Compare March 14, 2024 12:47
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer Kircheneer force-pushed the fix-295 branch 2 times, most recently from 96d7dbd to ee8c968 Compare March 14, 2024 13:15
@co-authored-by: Claudio Beretta <gioccher@users.noreply.github.com>
@Kircheneer Kircheneer merged commit 75f99f8 into nautobot:develop Mar 14, 2024
16 checks passed
@Kircheneer Kircheneer mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypedDict fields should support lookups that span relationships
3 participants