Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install with all integrations disabled still creates every integrations custom fields from signals #416

Closed
jeffkala opened this issue Apr 4, 2024 · 2 comments

Comments

@jeffkala
Copy link

jeffkala commented Apr 4, 2024

Environment

  • Python version: 3.11
  • Nautobot version: 2.1
  • nautobot-ssot version: 2.4, 2.5, and develop branch

Expected Behavior

For disabled integrations the custom fields shouldn't be created, utils.py should be properly not running signals for integrations that are disabled.

Observed Behavior

Even with disabled integrations (enable_{{ integration name}}=False) it still triggers the signal for the integration to create all the default CF fields.

Steps to Reproduce

  1. fresh install
  2. use all defaults for plugin_config
  3. Start app.
@jeffkala
Copy link
Author

jeffkala commented Apr 4, 2024

worker-1      | 15:52:27.864 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.jobs.examples.ExampleDataSource
worker-1      | 15:52:27.871 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.jobs.examples.ExampleDataTarget
worker-1      | 15:52:27.872 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.ipfabric.jobs.IpFabricDataSource
worker-1      | 15:52:27.872 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.infoblox.jobs.InfobloxDataSource
worker-1      | 15:52:27.872 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.infoblox.jobs.InfobloxDataTarget
worker-1      | 15:52:27.873 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.servicenow.jobs.ServiceNowDataTarget
worker-1      | 15:52:27.873 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.device42.jobs.Device42DataSource
worker-1      | 15:52:27.873 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.aci.jobs.AciDataSource
worker-1      | 15:52:27.873 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.aristacv.jobs.CloudVisionDataSource
worker-1      | 15:52:27.874 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_ssot.integrations.aristacv.jobs.CloudVisionDataTarget
worker-1      | 15:52:27.881 DEBUG   nautobot.ssot        utils.py        each_enabled_integration_module() : Integration ipfabric does not have a urls module, skipping.
worker-1      | 15:52:27.881 DEBUG   nautobot.ssot        utils.py        each_enabled_integration_module() : Integration infoblox does not have a urls module, skipping.
worker-1      | 15:52:27.883 DEBUG   nautobot.ssot        utils.py        each_enabled_integration_module() : Integration device42 does not have a urls module, skipping.
worker-1      | 15:52:27.883 DEBUG   nautobot.ssot        utils.py        each_enabled_integration_module() : Integration aci does not have a urls module, skipping.
worker-1      | 15:52:27.883 DEBUG   nautobot.ssot        utils.py        each_enabled_integration_module() : Integration aristacv does not have a urls module, skipping.
worker-1      | 15:52:27.888 DEBUG   nautobot.core.celery __init__.py        import_jobs_as_celery_tasks() : Importing system Jobs
worker-1      | 15:52:27.888 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot.core.jobs.ExportObjectList
worker-1      | 15:52:27.889 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot.core.jobs.GitRepositorySync
worker-1      | 15:52:27.889 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot.core.jobs.GitRepositoryDryRun
worker-1      | 15:52:28.971 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_device_lifecycle_mgmt.jobs.lifecycle_reporting.DeviceSoftwareValidationFullReport
worker-1      | 15:52:28.971 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_device_lifecycle_mgmt.jobs.lifecycle_reporting.InventoryItemSoftwareValidationFullReport
worker-1      | 15:52:28.972 DEBUG   nautobot.core.celery __init__.py                      register_jobs() : Registering job nautobot_device_lifecycle_mgmt.jobs.cve_tracking.GenerateVulnerabilities
worker-1      | 15:52:28.991 DEBUG   nautobot.ssot        __init__.py                              ready() : Registering signals for /source/nautobot_ssot/integrations/ipfabric/signals.py
worker-1      | 15:52:28.992 DEBUG   nautobot.ssot        __init__.py                              ready() : Registering signals for /source/nautobot_ssot/integrations/infoblox/signals.py
worker-1      | 15:52:28.992 DEBUG   nautobot.ssot        __init__.py                              ready() : Registering signals for /source/nautobot_ssot/integrations/servicenow/signals.py
worker-1      | 15:52:28.992 DEBUG   nautobot.ssot        __init__.py                              ready() : Registering signals for /source/nautobot_ssot/integrations/device42/signals.py
worker-1      | 15:52:28.993 DEBUG   nautobot.ssot        __init__.py                              ready() : Registering signals for /source/nautobot_ssot/integrations/aci/signals.py
worker-1      | 15:52:28.993 DEBUG   nautobot.ssot        __init__.py                              ready() : Registering signals for /source/nautobot_ssot/integrations/aristacv/signals.py
worker-1      | celery beat v5.3.5 (emerald-rush) is starting.
worker-1      | 15:52:29.579 DEBUG   nautobot.core.celery __init__.py        import_jobs_as_celery_tasks() : Importing system Jobs

@jeffkala
Copy link
Author

jeffkala commented Apr 4, 2024

Looks like this was a misconfig on my end during testing.

@jeffkala jeffkala closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant