Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Button and Developer Experience Updates #57

Merged
merged 4 commits into from Aug 18, 2022
Merged

Action Button and Developer Experience Updates #57

merged 4 commits into from Aug 18, 2022

Conversation

jvanderaa
Copy link
Contributor

Fixes #56

  • Updates the action buttons to follow best practices from Nautobot core.
  • Updates healthcheck to not be used on docs container, was causing a lot of extra noise
  • Updates README to help with copy and paste for getting started

@jvanderaa jvanderaa changed the title Jv action button updates Action Button and Developer Experience Updates Aug 18, 2022
@LoneStar-Swish
Copy link
Contributor

I'm not set up currently to test, but from reviewing the changed files I don't see why anything would change function wise. Looks good to me.

@smk4664 smk4664 merged commit 54e7cf4 into nautobot:develop Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@LoneStar-Swish LoneStar-Swish LoneStar-Swish approved these changes

@chadell chadell Awaiting requested review from chadell chadell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError on accessing ManufacturerListView or DeviceTypeListView under Nautobot 1.3
4 participants
@jvanderaa @LoneStar-Swish @glennmatthews @smk4664