Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds 'tags' to the fields on PeerGroupTemplateForm #148

Merged
merged 1 commit into from
Apr 3, 2024
Merged

adds 'tags' to the fields on PeerGroupTemplateForm #148

merged 1 commit into from
Apr 3, 2024

Conversation

Kircheneer
Copy link
Contributor

@Kircheneer Kircheneer commented Oct 20, 2023 •
edited by mzbroch
Loading

  • PeerGroupTemplateForm tags fixed by Viewsets migration in 2.0

Solves #190

@Kircheneer
Copy link
Contributor Author

CI failure is not caused by this I believe

glennmatthews
glennmatthews reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this may also be needed on PeerGroupForm and PeerGroupTemplateForm?

@Kircheneer
Copy link
Contributor Author

Looks like this may also be needed on PeerGroupForm and PeerGroupTemplateForm?

Addressed!

@glennmatthews
Copy link
Contributor

Looks like we need to fix CI to not test develop against upstream stable (i.e. 2.0.x) for now since develop is the 1.x-compatible branch for the time being.

@mzbroch mzbroch force-pushed the add-tag-to-peer-endpoint-form branch from ae06bc6 to 534f29f Compare April 3, 2024 14:58
@mzbroch mzbroch changed the title adds 'tags' to the fields on PeerEndpointForm adds 'tags' to the fields on PeerGroupTemplateForm Apr 3, 2024
@mzbroch mzbroch force-pushed the add-tag-to-peer-endpoint-form branch from 534f29f to 70fc21a Compare April 3, 2024 15:03
@mzbroch mzbroch merged commit 05c05b5 into nautobot:develop Apr 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@mzbroch mzbroch Awaiting requested review from mzbroch mzbroch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kircheneer @glennmatthews @mzbroch