Add new Gmail API Service Account Source type #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
force-pushed
the
issue15-add-gmail-api-source
branch
from
3a76940
to
70548f6
Compare
chadell
force-pushed
the
issue15-add-gmail-api-source
branch
from
70548f6
to
4762ca4
Compare
|
@glennmatthews , this PR still needs to add documentation on setting this up (Jonathan will help me with as there is some admin stuff to be done in Google console) and include testing to new methods. |
chadell
changed the title
|
@glennmatthews , taking into account that I still have to update Readme with the instructions to use the new Notification Source, the PR is decently ready for review |
chadell
force-pushed
the
issue15-add-gmail-api-source
branch
from
dbc7555
to
b86e5f0
Compare
|
I added on to the API instructions and made a couple small grammar changes. If I need to expand on anything let me know. |
glennmatthews
previously approved these changes
Jun 18, 2021
itdependsnetworks
pushed a commit
to itdependsnetworks/nautobot-app-circuit-maintenance
that referenced
this pull request
Apr 3, 2024
…autobot#26) * Refactor library to allow a Provider to concatenate multiple parsers * Remove unused sender, source and subject attributes Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
EmailSourceclass that will concentrate some methods and attributes valid either for IMAP or Gmail API. This is more concrete than theSourcethat could eventually fetch directly REST API with JSON data (for instance)