Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible mapping provider to parser #51

Merged
merged 4 commits into from Aug 7, 2021

Conversation

chadell
Copy link
Contributor

@chadell chadell commented Aug 5, 2021

This PR addresses issue #43

It creates a new custom field in Provider that can be used to define a custom Provider name in the circuit-maintenance-parser library, and when not provider, the Provider.slug would be used, same as today.

@chadell chadell force-pushed the flexible-mapping-provider-to-parser branch from 9567288 to b65b612 Compare August 5, 2021 16:06
@chadell chadell changed the title [WIP] Flexible mapping provider to parser Flexible mapping provider to parser Aug 5, 2021
@chadell chadell marked this pull request as ready for review August 5, 2021 16:07
glennmatthews
glennmatthews previously approved these changes Aug 6, 2021
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could use an update to README.md to explain this new functionality? Otherwise looks good!

@chadell
Copy link
Contributor Author

chadell commented Aug 7, 2021

@glennmatthews I'm gonna merge this as it's already approved and 3985590 only updated the Readme and Changelog

@chadell chadell merged commit 8a8d272 into develop Aug 7, 2021
@chadell chadell deleted the flexible-mapping-provider-to-parser branch August 7, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants