Fix Reports #84
Merged
Fix Reports #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reports won't work without these settings so they're required for the plugin to work. Updating documentaiton and marking as required in plugin should fix the issue.
jvanderaa
requested changes
Apr 8, 2022
| @@ -29,7 +29,7 @@ class DeviceLifeCycleConfig(PluginConfig): | |||
| author_email = "opensource@networktocode.com" | |||
| description = "Manages device lifecycle of Nautobot Devices and Components." | |||
| base_url = "nautobot-device-lifecycle-mgmt" | |||
| required_settings = [] | |||
| required_settings = ["barchart_bar_width", "barchart_width", "barchart_height"] | |||
| min_version = "1.0.0" | |||
| max_version = "1.9999" | |||
| default_settings = {"expired_field": "end_of_support"} | |||
There was a problem hiding this comment.
@jdrew82 can we add those defaults here as well?
jvanderaa
approved these changes
Apr 8, 2022
|
@progala @josh-silvas what are the thoughts here? |
|
LGTM. Thanks @jdrew82 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make the required changes to fix #83.