Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign default custom fields values to new objects #13

Merged
merged 1 commit into from Jul 31, 2021
Merged

Conversation

mzbroch
Copy link
Contributor

@mzbroch mzbroch commented May 30, 2021

This PR provides following modifications

  • Assign default custom fields values to new objects
  • Validated save for created objects
  • Fix for missing status in IP Address
  • Fix device role colour default value

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

raise OnboardException(
reason="fail-general",
message=f"ERROR multiple IP Address status using same name: {default_status_name}",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test cases needed for this logic?

Validated save for created objects
Fix for missing status in IP Address
Fix device role colour
@mzbroch mzbroch merged commit 301d67e into develop Jul 31, 2021
@mzbroch mzbroch deleted the develop-cf branch July 31, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants