Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit for dynamic group change #288

Merged
merged 15 commits into from Aug 6, 2022
Merged

initial commit for dynamic group change #288

merged 15 commits into from Aug 6, 2022

Conversation

whitej6
Copy link
Contributor

@whitej6 whitej6 commented Jul 11, 2022

No description provided.

itdependsnetworks
itdependsnetworks reviewed Jul 12, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
jeffkala
jeffkala requested changes Jul 12, 2022
View reviewed changes
nautobot_golden_config/models.py Outdated Show resolved Hide resolved
nautobot_golden_config/jobs.py Show resolved Hide resolved
nautobot_golden_config/jobs.py Show resolved Hide resolved
@jeffkala jeffkala mentioned this pull request Jul 12, 2022
Closed
This was referenced Jul 13, 2022
Closed
Closed
@itdependsnetworks
Copy link
Contributor

Inline comment aside, this looks good.

@itdependsnetworks itdependsnetworks linked an issue Jul 20, 2022 that may be closed by this pull request
Convert Scope to Dynamic Groups #268
Closed
itdependsnetworks
itdependsnetworks reviewed Aug 2, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@itdependsnetworks
Copy link
Contributor

Two comments aside, everything looks good. I would like to give it a test drive as the html is a bit much for me to digest.

jeffkala
jeffkala reviewed Aug 3, 2022
View reviewed changes
nautobot_golden_config/api/serializers.py Outdated Show resolved Hide resolved
nautobot_golden_config/api/serializers.py Show resolved Hide resolved
nautobot_golden_config/models.py Outdated Show resolved Hide resolved
whitej6 and others added 3 commits August 3, 2022 12:59
@whitej6 @jeffkala
Update nautobot_golden_config/api/serializers.py
e963717 
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
@whitej6 @jeffkala
Update nautobot_golden_config/models.py
5a4d5db 
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
update test & add comment
73272bb
@itdependsnetworks itdependsnetworks merged commit b029bfc into nautobot:develop Aug 6, 2022
@itdependsnetworks itdependsnetworks mentioned this pull request Aug 10, 2022
Closed
jmpettit pushed a commit to jmpettit/nautobot-app-golden-config that referenced this pull request Jan 30, 2024
@whitej6 @jeffkala
initial commit for dynamic group change (nautobot#288)
c41961a 
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks itdependsnetworks left review comments

@jeffkala jeffkala jeffkala approved these changes

@nkallergis nkallergis Awaiting requested review from nkallergis nkallergis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Scope to Dynamic Groups
3 participants
@whitej6 @itdependsnetworks @jeffkala