Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cisco ACI integration #136

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Add Cisco ACI integration #136

merged 3 commits into from
Jul 7, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jun 9, 2023 •
edited

Closes #129

  • Adds Cisco ACI integration from nautobot-plugin-ssot-aci.

TODO

  • Test integration.

@snaselj
chore: Added ACI files
2ab10b0
@snaselj
chore: Integrate ACI files
f188c7a 
- Updated App configuration reading.
- Resolved QA issues (pylint, bandit).
- Removed unnecesary basic test.
- Registered signals.
Base automatically changed from u/snaselj-115-integrations to develop June 12, 2023 15:04
@snaselj
Copy link
Contributor Author

snaselj commented Jun 12, 2023

Merged with the latest develop to resolve conflicts.

@snaselj snaselj marked this pull request as ready for review June 12, 2023 16:41
@snaselj snaselj requested a review from a team as a code owner June 12, 2023 16:41
@chadell
Copy link
Contributor

chadell commented Jun 21, 2023

@dnewood could you review it?

@chadell chadell requested a review from dnewood June 21, 2023 07:19
@chadell chadell mentioned this pull request Jul 4, 2023
Closed
chadell
chadell approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jdrew82 this is ready to merge. I have tested it and it works as expected.

@jdrew82 jdrew82 merged commit dc803d2 into develop Jul 7, 2023
16 checks passed
@jdrew82 jdrew82 deleted the u/snaselj-129-aci branch July 7, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

@dnewood dnewood Awaiting requested review from dnewood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Cisco ACI SSoT Plugin to This Repo
3 participants
@snaselj @chadell @jdrew82