Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPFabric integration #137

Merged
merged 23 commits into from
Sep 1, 2023
Merged

Add IPFabric integration #137

merged 23 commits into from
Sep 1, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jun 9, 2023 •
edited by alhogan

Closes #130

  • Adds IPFabric integration from nautobot-plugin-ssot-ipfabric.

TODO

  • Test integration.
  • Fix configuration.
  • Bump dependency to the IPFabric integraton version of nautobot-chatops App.

snaselj
snaselj commented Jun 12, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
Base automatically changed from u/snaselj-115-integrations to develop June 12, 2023 15:04
@snaselj snaselj mentioned this pull request Jun 13, 2023
Closed
@chadell chadell mentioned this pull request Jul 4, 2023
Closed
@snaselj
Copy link
Contributor Author

snaselj commented Aug 8, 2023

Merged with the latest develop to resolve conflicts

@snaselj snaselj mentioned this pull request Aug 9, 2023
Merged
bryanculver
bryanculver reviewed Aug 9, 2023
View reviewed changes
pyproject.toml Outdated
@@ -81,7 +81,7 @@ mkdocstrings-python = "0.8.3"
requests-mock = "^1.10.0"
parameterized = "^0.8.1"
myst-parser = "^0.15.2"
nautobot-chatops = "^2.0.0"
nautobot-chatops = { version = "^2.0.2", extras = ["ipfabric"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.2 doesn't exist yet. 2.0.1 was just released. Please update the lockfile after this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@snaselj
Copy link
Contributor Author

snaselj commented Aug 17, 2023 •
edited

Blocked by #157 due to the following dependency: https://github.com/nautobot/nautobot-plugin-ssot/pull/137/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R84

@snaselj snaselj mentioned this pull request Aug 23, 2023
Merged
4 tasks
@snaselj snaselj marked this pull request as ready for review August 23, 2023 10:30
@snaselj snaselj requested a review from a team as a code owner August 23, 2023 10:30
chadell
chadell reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the integration makes sense. I would only ask @alhogan or @pke11y to test it and verify that it works as expected

@alhogan
Copy link
Contributor

alhogan commented Aug 23, 2023

I will carve out some time to test it this week.

@alhogan
Copy link
Contributor

alhogan commented Aug 30, 2023

I ran a few tests and saw some discrepancies in the number of objects been created/updated/deleted. I will dig a little deeper into the results to see what is causing this and provide an update shortly.

@Kircheneer Kircheneer added the status: action required This issue requires additional information to be actionable label Aug 31, 2023
@alhogan
Copy link
Contributor

alhogan commented Sep 1, 2023

Found the source of the discrepancies. Null interface descriptions were throwing false-positives in the diff. Fix has been implemented and we should be good to go on merging this one.
Screen Shot 2023-08-31 at 6 50 21 PM

@jdrew82 jdrew82 merged commit 9006390 into develop Sep 1, 2023
15 checks passed
@jdrew82 jdrew82 deleted the u/snaselj-130-ipfabric branch September 1, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver left review comments

@chadell chadell chadell left review comments

Assignees
No one assigned
Labels
status: action required This issue requires additional information to be actionable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate IP Fabric SSoT Plugin to This Repo
7 participants
@snaselj @alhogan @bryanculver @chadell @jdrew82 @Kircheneer @pke11y