-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arista CloudVision integration #138
Conversation
0e37d38
to
6bc16f1
Compare
Rebased on top of develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see you updating the Dockerfile for the dev environment here. We should have that added so the dev environment has the App for coding against.
Is there anything else you are missing in the Dockerfile? |
I addressed this in an above comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@snaselj can you rebase this on develop so the conflicts go away? |
This should be ready to merge once the rebase happens or conflicts are fixed. |
Conflicts are resolved by merging to the latest |
Closes #132
TODO