Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arista CloudVision integration #138

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Add Arista CloudVision integration #138

merged 5 commits into from
Jul 10, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jun 12, 2023

Closes #132

  • Adds Arista CloudVision integration from nautobot-plugin-ssot-arista-cloudvision.

TODO

  • Test integration.

Base automatically changed from u/snaselj-115-integrations to develop June 12, 2023 15:04
@snaselj
Copy link
Contributor Author

snaselj commented Jun 12, 2023

Rebased on top of develop

@snaselj snaselj marked this pull request as ready for review June 12, 2023 16:42
@snaselj snaselj requested a review from a team as a code owner June 12, 2023 16:42
@chadell
Copy link
Contributor

chadell commented Jun 21, 2023

@qduk @jdrew82 could you review it?

@chadell chadell requested review from jdrew82 and qduk June 21, 2023 07:18
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see you updating the Dockerfile for the dev environment here. We should have that added so the dev environment has the App for coding against.

pyproject.toml Outdated Show resolved Hide resolved
@snaselj
Copy link
Contributor Author

snaselj commented Jun 22, 2023

I don't see you updating the Dockerfile for the dev environment here. We should have that added so the dev environment has the App for coding against.

[all] and dev dependencies are installed to dev image from poetry / pip, poetry.lock is updated.

Is there anything else you are missing in the Dockerfile?

@jdrew82
Copy link
Contributor

jdrew82 commented Jun 23, 2023

I don't see you updating the Dockerfile for the dev environment here. We should have that added so the dev environment has the App for coding against.

[all] and dev dependencies are installed to dev image from poetry / pip, poetry.lock is updated.

Is there anything else you are missing in the Dockerfile?

I addressed this in an above comment.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chadell chadell mentioned this pull request Jul 4, 2023
@jdrew82
Copy link
Contributor

jdrew82 commented Jul 7, 2023

@snaselj can you rebase this on develop so the conflicts go away?

@jdrew82
Copy link
Contributor

jdrew82 commented Jul 7, 2023

This should be ready to merge once the rebase happens or conflicts are fixed.

@snaselj
Copy link
Contributor Author

snaselj commented Jul 10, 2023

This should be ready to merge once the rebase happens or conflicts are fixed.

Conflicts are resolved by merging to the latest develop.

@snaselj snaselj mentioned this pull request Jul 10, 2023
2 tasks
@jdrew82 jdrew82 merged commit 9d4b1b0 into develop Jul 10, 2023
16 checks passed
@jdrew82 jdrew82 deleted the u/snaselj-132-aristacv branch July 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Arista CloudVision SSoT Plugin to This Repo
5 participants