Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DjangoJSONEncoder for diff field #146

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Use DjangoJSONEncoder for diff field #146

merged 1 commit into from
Jul 4, 2023

Conversation

jmcgill298
Copy link
Contributor

The DjangoJSONEncoder provide JSON encoding for additional object types, such as datetime and uuid objects, two types that are often used in the Sync.diff field.

@jmcgill298 jmcgill298 requested a review from a team as a code owner July 3, 2023 19:47
@jmcgill298 jmcgill298 linked an issue Jul 3, 2023 that may be closed by this pull request
TypeError: Object of type date is not JSON serializable #45
Closed
chadell
chadell approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell
Copy link
Contributor

chadell commented Jul 4, 2023

fixes #45

@Kircheneer Kircheneer merged commit 77ab84a into develop Jul 4, 2023
16 checks passed
@chadell chadell deleted the jacobm/json_encoding branch July 4, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Object of type date is not JSON serializable
3 participants
@jmcgill298 @chadell @Kircheneer