Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Integrations #152

Merged
merged 29 commits into from
Sep 8, 2023
Merged

Finalize Integrations #152

merged 29 commits into from
Sep 8, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jul 27, 2023

Closes NaN

Finish adding integrations.

Done

  • Added Cisco ACI documentation.
  • Added conflicting apps assertion.

To-Do

  • Add Arista CloudVision integration documentation.
  • Add Infoblox integration documentation.
  • Add IPFabric integration documentation.
  • Add ServiceNow integration documentation.

@snaselj snaselj requested a review from a team as a code owner July 27, 2023 16:45
@snaselj snaselj marked this pull request as draft July 27, 2023 16:45
@snaselj
Copy link
Contributor Author

snaselj commented Jul 27, 2023

Added Cisco ACI documentation to this PR. Please check it, once agreed, I'll add other integrations in the same way.

@jdrew82 @cmsirbu

Copy link
Contributor

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Don't forget to also add the contributor thanks in the readme for all the individual repos the integrations came from.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/admin/install.md Outdated Show resolved Hide resolved
docs/admin/install.md Outdated Show resolved Hide resolved
docs/admin/install.md Outdated Show resolved Hide resolved
docs/user/integrations.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/user/aci.md Outdated Show resolved Hide resolved
docs/user/aci.md Outdated Show resolved Hide resolved
docs/user/aci.md Outdated Show resolved Hide resolved
@snaselj
Copy link
Contributor Author

snaselj commented Aug 14, 2023

Looks good! Don't forget to also add the contributor thanks in the readme for all the individual repos the integrations came from.

All comments are addressed now, could you pls. check it @cmsirbu ?

README.md Outdated Show resolved Hide resolved
docs/admin/install.md Outdated Show resolved Hide resolved
docs/admin/install.md Outdated Show resolved Hide resolved
docs/admin/upgrade.md Outdated Show resolved Hide resolved
@cmsirbu
Copy link
Contributor

cmsirbu commented Aug 16, 2023

You'll also need to add the admin integrations to mkdocs.yml and an admin/integrations/index.md file to list them just like the user guide one.

   - Administrator Guide:
       - Install and Configure: "admin/install.md"
+      - Integrations:
+          - "admin/integrations/index.md"
+          - Cisco ACI: "admin/integrations/aci_setup.md"

@snaselj
Copy link
Contributor Author

snaselj commented Aug 18, 2023

@cmsirbu

Added Arista CloudVision integration, could you pls. check it?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the structure! let's move it forward

Co-authored-by: Christian Adell <chadell@gmail.com>
@snaselj
Copy link
Contributor Author

snaselj commented Aug 23, 2023

Blocked by #137

@snaselj snaselj marked this pull request as ready for review August 23, 2023 09:56
@snaselj
Copy link
Contributor Author

snaselj commented Aug 23, 2023

Added all integrations documentation, it's ready for review now.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks but mostly looking good!

README.md Outdated Show resolved Hide resolved
docs/admin/integrations/aristacv_setup.md Outdated Show resolved Hide resolved
docs/user/app_overview.md Show resolved Hide resolved
docs/admin/upgrade.md Outdated Show resolved Hide resolved
docs/dev/jobs.md Outdated Show resolved Hide resolved
@snaselj
Copy link
Contributor Author

snaselj commented Aug 29, 2023

Just a few tweaks but mostly looking good!

Thanks, PR is fixed now.

@jdrew82
Copy link
Contributor

jdrew82 commented Sep 1, 2023

@snaselj Looks like there's a conflict with the nautobot_config.py file. Can we get that resolved? Looks good otherwise.

@snaselj
Copy link
Contributor Author

snaselj commented Sep 1, 2023

Conflicts are resolved now @jdrew82

@chadell
Copy link
Contributor

chadell commented Sep 5, 2023

still one conflict with mkdocs.yml and docs/user/developing_jobs.md, @snaselj

@snaselj
Copy link
Contributor Author

snaselj commented Sep 5, 2023

Another set of conflicts resolved now @chadell

@chadell
Copy link
Contributor

chadell commented Sep 6, 2023

Code Reference

I don't see the code reference doc (Code Reference: "user/reference.md") changing...

Could you point me out on what's different?

Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaselj
Copy link
Contributor Author

snaselj commented Sep 8, 2023

Merged user code reference into developer and fixed some warnings during mkdocs build.

This PR should be done.

@jdrew82 @chadell

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit f8d8d62 into develop Sep 8, 2023
15 checks passed
@jdrew82 jdrew82 deleted the u/snaselj-finish-integrations branch September 8, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants