Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeviceTypeImporter #1

Merged
merged 11 commits into from Apr 17, 2021
Merged

Add DeviceTypeImporter #1

merged 11 commits into from Apr 17, 2021

Conversation

smk4664
Copy link
Contributor

@smk4664 smk4664 commented Apr 9, 2021

Still a WIP... But I wanted to get something up sooner than later.

merlin/views.py Outdated Show resolved Hide resolved
@smk4664 smk4664 changed the title WIP: Initial push of the DeviceTypeImporter. Add DeviceTypeImporter Apr 15, 2021
@smk4664
Copy link
Contributor Author

smk4664 commented Apr 15, 2021

This is now ready for review.

@smk4664 smk4664 requested a review from jvanderaa April 15, 2021 17:21
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor default to prevent some errors.

merlin/jobs.py Show resolved Hide resolved
merlin/tests/test_views.py Show resolved Hide resolved
Co-authored-by: Josh VanDeraa <jv@networktocode.com>
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cover it. I forgot about the linters not liking {} in the args.

merlin/jobs.py Outdated Show resolved Hide resolved
Co-authored-by: Josh VanDeraa <jv@networktocode.com>
@smk4664 smk4664 merged commit 22315b8 into nautobot:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants