Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide health check for celery beat #1102

Closed
nniehoff opened this issue Nov 24, 2021 · 6 comments · Fixed by #5428
Closed

Provide health check for celery beat #1102

nniehoff opened this issue Nov 24, 2021 · 6 comments · Fixed by #5428
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone

Comments

@nniehoff
Copy link
Contributor

Environment

  • Python version: 3.6
  • Nautobot version: 1.2.0b1

We need to provide a healthcheck for Celery Beat. In the docker-compose development file, we are using nautobot-server health_check for the Celery pods today. Unfortunately, this health check doesn't check the health of the Celery worker or Celery beat. The helm chart uses a slightly different approach for the celery worker which is:

nautobot-server celery inspect ping --destination celery@$HOSTNAME

This works great for the Celery workers, but it doesn't work for Celery beat. In some quick research, we may need to implement a simple function to make this happen. I wanted to get this open before we ship 1.2.

@gneville-ot
Copy link

@nniehoff - Is there any update to this?

I've spotted that the health check applied to celery-beat in the Helm charts is nautobot-server celery inspect ping --destination celery@$HOSTNAME but won't work

@lampwins lampwins added this to the v2.2 milestone Feb 2, 2024
@Kircheneer
Copy link
Contributor

Kircheneer commented Feb 23, 2024

Possibly something like this can help? celery/celery#4079 (comment)

We are trialing this for the normal workers in a K8S environment

@glennmatthews
Copy link
Contributor

That looks to be worker-specific to me, and what we're looking for in this issue is a healthcheck for beat rather than the workers. Thanks though!

@Kircheneer
Copy link
Contributor

I thought that maybe there would be beat signals to cover the functionality, but it appears there is only beat-init and nothing after that.

@glennmatthews
Copy link
Contributor

Desirable in LTM as well.

@glennmatthews
Copy link
Contributor

Backported in #5430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Status: To Groom
Development

Successfully merging a pull request may close this issue.

6 participants