New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change logging for custom field deletion clean-up task #1631
Comments
I think more generally this is a gap for all of our custom field background updates (such as populating default values for a newly created custom field). |
I think a "complete" fix here would involve all of the following background task functions in
For all of the above, if no data is changed on a given model instance, an ObjectChange should not be generated for that specific instance. |
This is going to require some more effort than initially estimated.
|
Some of this work was completed but depends on the change logging improvements in #2236 in order to log changes by the user responsible for triggering the background task. |
Probably just need to convert these custom celery tasks to system jobs. |
Need to account for users in the ORM case. |
It probably doesn't make sense to make this a system job yet since we still don't support running jobs without a user (the ORM case here). We should be able to introspect |
Always attempt to the user by whatever means are available (change context for example). As a last resort, allow system jobs to run without a user. |
In addition to the work already done for #1582 on this PR, we need to add change logging for each updated object in nautobot.extras.tasks.delete_custom_field_data code here
The text was updated successfully, but these errors were encountered: