Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate plugin development guide from setup.py to Poetry #175

Closed
jathanism opened this issue Mar 19, 2021 · 3 comments · Fixed by #237
Closed

Migrate plugin development guide from setup.py to Poetry #175

jathanism opened this issue Mar 19, 2021 · 3 comments · Fixed by #237
Assignees
@jvanderaa
Labels
type: documentation Improvements or additions to documentation
Projects
Release v1.0.0
Milestone
v1.0.0

Comments

@jathanism
Copy link
Contributor

Proposed Changes

Currently the Plugin guide directs the reader to create a setup.py and to use setup.py develop to develop plugins.

Justification

We'll want to revise this section at some point to use Poetry and pyproject.toml instead of setup.py, since all of our "official" plugins use those.
@jathanism jathanism added the type: documentation Improvements or additions to documentation label Mar 19, 2021
@jathanism jathanism added this to the v1.0.0 milestone Mar 19, 2021
@jedelman8
Copy link
Contributor

@jathanism are you taking this?

@jathanism
Copy link
Contributor Author

Sure unless someone else is feeling plucky!

@jathanism jathanism added this to To do in Release v1.0.0 Mar 24, 2021
@jvanderaa
Copy link
Contributor

I can take this one @jathanism if you would like.

@jedelman8 jedelman8 moved this from To do to In progress in Release v1.0.0 Apr 1, 2021
@jvanderaa jvanderaa mentioned this issue Apr 3, 2021
Merged
Release v1.0.0 automation moved this from In progress to Done Apr 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jvanderaa jvanderaa

Labels
type: documentation Improvements or additions to documentation
Projects
No open projects
Release v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Updates Plugin Development Docs to use Poetry jvanderaa/nautobot
3 participants
@jathanism @jedelman8 @jvanderaa