Apps Refactor: Refactor all imports to use module namespaces

[jathanism]

Proposed Changes

Currently in the code base there are many examples of large imports into the global namespace. For example, here is a sample of forms-related imports from nautobot/extras/forms.py:

from django import forms

from nautobot.utilities.forms import (
    add_blank_choice,
    APISelectMultiple,
    BootstrapMixin,
    BulkEditForm,
    BulkEditNullBooleanSelect,
    ColorSelect,
    CSVModelChoiceField,
    CSVModelForm,
    CSVMultipleContentTypeField,
    DateTimePicker,
    DynamicModelChoiceField,
    DynamicModelMultipleChoiceField,
    JSONField,
    MultipleContentTypeField,
    SlugField,
    StaticSelect2,
    StaticSelect2Multiple,
    BOOLEAN_WITH_BLANK_CHOICES,
)

I'm proposing we move to this pattern:

from django import forms as djforms  # Django forms module
from nautobot.utilities import forms  # Our utilities.forms module
from nautobot.dcim import models as dcim_models  # DCIM models
    
 # In code..
class SomeForm(forms.CustomFieldModelForm, djforms.ModelForm):
    name = djforms.CharField(required=False)
    device = forms.CSVModelChoiceField(queryset=dcim_models.Device.objects.all())

    class Meta:
        model = dcim_models.Device

Justification

The current pattern is not only is unwieldy, but complicates merges, rebases, and refactors and in some cases can result in circular imports.

This way it's clear what is coming from Django forms and what is coming from internal forms modules, and any time something new is needed or used from nautobot.utilities.forms it doesn't need to be explicitly imported.

This also applies to more than just forms, but I was just selecting forms as a singular example of imports for a single module.

TODO

• update module imports and add module import section to best practices #2794
• Refactor imports utilities app #2872
• Refactor imports in core app #2866
• Refactor imports in dcim app #2867
• Refactor imports in extras app #2868
• Refactor imports in ipam app #2869
• Refactor imports in tenancy app #2870
• Refactor imports in users app #2871

Related

• Resolve circular import workarounds #2873

[bryanculver]

We should get this codified into best practices and work towards this in every PR. If you touch it, update it.

[gsnider2195]

Script to automate refactoring of imports

refactor_imports.zip