Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent jobs from running if has sensitive variables and requires approval #2380

Merged
merged 8 commits into from
Sep 15, 2022
Merged

Prevent jobs from running if has sensitive variables and requires approval #2380

merged 8 commits into from
Sep 15, 2022

Conversation

timizuoebideri1
Copy link
Contributor

Closes: #2201

What's Changed

TODO

  • Explanation of Change(s)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

glennmatthews
glennmatthews requested changes Sep 7, 2022
View reviewed changes
nautobot/extras/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/extras/templates/extras/job.html Outdated Show resolved Hide resolved
nautobot/extras/templates/extras/job.html Outdated Show resolved Hide resolved
nautobot/extras/views.py Outdated Show resolved Hide resolved
nautobot/extras/views.py Show resolved Hide resolved
timizuoebideri1 and others added 3 commits September 9, 2022 06:28
@timizuoebideri1 @glennmatthews
Update nautobot/extras/tables.py
97b92c7 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@timizuoebideri1 @bryanculver
Update nautobot/extras/tests/test_views.py
b124ed9 
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@timizuoebideri1
black
1511a2b
glennmatthews
glennmatthews approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog fragment before merging; otherwise this looks good to me!

@glennmatthews
Copy link
Contributor

Spoke too soon - I missed that the tests are not passing yet. :-)

@glennmatthews glennmatthews merged commit 05cf0e8 into develop Sep 15, 2022
@bryanculver bryanculver deleted the has_sensitive_jobs_bug branch November 15, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@gsnider2195 gsnider2195 Awaiting requested review from gsnider2195

@HanlinMiao HanlinMiao Awaiting requested review from HanlinMiao

@bryanculver bryanculver Awaiting requested review from bryanculver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jobs with has_sensitive_variables=True can be scheduled and arguments stored in the database
4 participants
@timizuoebideri1 @glennmatthews @bryanculver @gsnider2195