Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy button - not working for ip address #2406

Closed
david-kn opened this issue Sep 12, 2022 · 1 comment · Fixed by #2626
Closed

Copy button - not working for ip address #2406

david-kn opened this issue Sep 12, 2022 · 1 comment · Fixed by #2626
Assignees
Labels
type: bug Something isn't working as expected

Comments

@david-kn
Copy link
Contributor

david-kn commented Sep 12, 2022

Environment

  • Nautobot version (Docker tag too if applicable): 1.4.1
  • Python version: 3.7.13
    (tested also on demo nautobot)

Steps to Reproduce

  1. Open any device object with IP address assigned in Nautobot GUI
  2. Click on a "copy" button next to Primary IP address when hovering with mouse

Expected Behavior

The IP value should have been copied in clipboard.

Observed Behavior

Nothing is copied (if a clipboard contained something before, it stays there without any change).

Probably the issues is due to fact that the IP address HTML element is missing the ID ipv4 that is supposed to be used for element selection (see image) because the "copy" button works for device name though (in title) where element ID is properly defined.

btw. I didn't want to create two seperated issues for this topic / for another (un)expected behavior but are you aware that when the copy buton is used for a device name it copies tha device name + it adds a whitespace in front of and behind the name itself? The clipboard is NOT just the name itself (e.g. ams01-dist-01)

I would be nice to fix this and also extend in the future with already existing request: #1519 (just saying :-) )
image

TODO

@glennmatthews
Copy link
Contributor

Thanks for the report! Looks like this was broken by #1833.

@glennmatthews glennmatthews added type: bug Something isn't working as expected group: dcim labels Sep 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants