Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dynamic filter form to a list view that lacks this feature. #2617

Merged
merged 8 commits into from
Oct 24, 2022
Merged

Add a dynamic filter form to a list view that lacks this feature. #2617

merged 8 commits into from
Oct 24, 2022

Conversation

timizuoebideri1
Copy link
Contributor

@timizuoebideri1 timizuoebideri1 commented Oct 15, 2022 •
edited
Loading

Closes: #2348

What's Changed

Add dynamic filter form feature to Rack Elevation, Console Connections, Power Connections, Interface Connections

Screenshot 2022-10-17 at 8 50 34 PM

Screenshot 2022-10-17 at 8 51 05 PM

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

This was linked to issues Oct 16, 2022
Filter form UI revamp #1998
Closed
New filter form search box #2460
Closed
@timizuoebideri1 timizuoebideri1 removed a link to an issue Oct 16, 2022
New filter form search box #2460
Closed
12 tasks
glennmatthews
glennmatthews reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Would you mind providing a few screenshots of these updated pages with filters in effect?

changes/2617.added Outdated Show resolved Hide resolved
@timizuoebideri1 @glennmatthews
Update changes/2617.added
24a4bc5 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
glennmatthews reviewed Oct 18, 2022
View reviewed changes
nautobot/core/views/generic.py Show resolved Hide resolved
nautobot/core/views/generic.py Outdated Show resolved Hide resolved
nautobot/core/templates/generic/object_list.html Outdated Show resolved Hide resolved
@glennmatthews
Copy link
Contributor

Are we waiting on anything before merging this?

@timizuoebideri1 timizuoebideri1 merged commit 73391e7 into timizuo_filterform_revamp Oct 24, 2022
@timizuoebideri1 timizuoebideri1 deleted the timizuo_filterform_revamp-search_panel branch October 24, 2022 16:55
@glennmatthews glennmatthews mentioned this pull request Oct 25, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@jathanism jathanism Awaiting requested review from jathanism

@bryanculver bryanculver Awaiting requested review from bryanculver

@briddo briddo Awaiting requested review from briddo

@gsnider2195 gsnider2195 Awaiting requested review from gsnider2195

@HanlinMiao HanlinMiao Awaiting requested review from HanlinMiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter form UI revamp
2 participants
@timizuoebideri1 @glennmatthews