Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selecting a Related Path in Cable Trace View Fails to Load #2655

Merged
merged 9 commits into from Oct 24, 2022
Merged

Fix selecting a Related Path in Cable Trace View Fails to Load #2655

merged 9 commits into from Oct 24, 2022

Conversation

timizuoebideri1
Copy link
Contributor

Closes: #1741

What's Changed

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

glennmatthews
glennmatthews reviewed Oct 20, 2022
View reviewed changes
changes/2655.fixed Outdated Show resolved Hide resolved
nautobot/dcim/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/dcim/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/dcim/views.py Outdated Show resolved Hide resolved
timizuoebideri1 and others added 2 commits October 21, 2022 10:34
@timizuoebideri1 @glennmatthews
Apply suggestions from code review
a327c25 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@timizuoebideri1
update test add status
41d6fdb
@timizuoebideri1 timizuoebideri1 marked this pull request as ready for review October 21, 2022 17:43
timizuoebideri1 and others added 2 commits October 22, 2022 08:09
@timizuoebideri1 @glennmatthews
Update nautobot/dcim/views.py
3fea246 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@timizuoebideri1
Add to test
2e6d830
glennmatthews
glennmatthews approved these changes Oct 24, 2022
View reviewed changes
nautobot/dcim/tests/test_views.py Outdated Show resolved Hide resolved
@timizuoebideri1 timizuoebideri1 merged commit 72dba74 into develop Oct 24, 2022
@timizuoebideri1 timizuoebideri1 deleted the timizuo_selecting_a_cable_path branch October 24, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting a Related Path in Cable Trace View Fails to Load
2 participants
@timizuoebideri1 @glennmatthews