Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide version in footer for unauthenticated users #2683

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Hide version in footer for unauthenticated users #2683

merged 3 commits into from
Nov 1, 2022

Conversation

Jonher937
Copy link
Contributor

@Jonher937 Jonher937 commented Oct 25, 2022

Closes: #2682

What's Changed

  • Nautbot version number is hidden from the footer for unauthenticated users

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example

Note the version number being present next to the hostname in the before, but not in the after.

Before

before

After

after

@glennmatthews glennmatthews linked an issue Oct 25, 2022 that may be closed by this pull request
12 tasks
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable enough, although as @Kircheneer pointed out, there's still the unauthenticated /api/status/ endpoint to consider from a security standpoint (#1610).

Would you be willing to add a unit test for this rendering logic, probably in nautobot.core.tests.test_views.HomeViewTestCase?

@Jonher937
Copy link
Contributor Author

This looks reasonable enough, although as @Kircheneer pointed out, there's still the unauthenticated /api/status/ endpoint to consider from a security standpoint (#1610).

Would you be willing to add a unit test for this rendering logic, probably in nautobot.core.tests.test_views.HomeViewTestCase?

That was not my experience, see my comment in the issue.

Sure, the devcontainer seems broken for VSCode (requires "db" but db is not defined, amongst other things). I've pushed a commit with a test, let's hope I nailed it, but noone usually does on the first try 😅

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We might want to revisit the test case at some point to make it more robust but it's definitely good enough for now. Thank you!

@Jonher937
Copy link
Contributor Author

Sorry for the re-reviews. The CI only runs partial jobs since I'm a new contributor.

@glennmatthews glennmatthews merged commit 76aa0d1 into nautobot:develop Nov 1, 2022
@Jonher937 Jonher937 deleted the issue-282 branch November 1, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Nautobot version in footer for unauthenticated users Version exposed to unauthenticated users
2 participants