Fix tests that are failing after introduction of ipam factories #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
approved these changes
Oct 27, 2022
| @@ -1401,10 +1402,17 @@ def test_color(self): | |||
|
|
|||
| def test_search(self): | |||
| params = {"q": "active"} | |||
| self.assertEqual(self.filterset(params, self.queryset).qs.count(), 1) | |||
| value = self.queryset.values_list("pk", flat=True)[0] | |||
| q = Q(name__icontains="active") | Q(slug__icontains="active") | Q(content_types__model__icontains="active") | |||
There was a problem hiding this comment.
I assume the content-types filter is just matching the search() implementation? We don't actually have any models at present that match this, right?
There was a problem hiding this comment.
It shouldn't match on anything but we can't say for sure anymore now that the test fixtures are being randomly generated by factories. This should be the same Q object that's generated by the search filter's generate_query method but I didn't want to leverage a method in the filterset to test the filterset.
| @@ -638,22 +640,40 @@ def test_mode(self): | |||
|
|
|||
| def test_ip_addresses(self): | |||
| self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2) | ||
| vminterface_ct = ContentType.objects.get_for_model(VMInterface) | ||
| ipaddresses = list( | ||
| IPAddress.objects.filter(assigned_object_id__isnull=False, assigned_object_type=vminterface_ct.pk)[:2] |
There was a problem hiding this comment.
I think?
Suggested change
| IPAddress.objects.filter(assigned_object_id__isnull=False, assigned_object_type=vminterface_ct.pk)[:2] | |
| IPAddress.objects.filter(assigned_object_id__isnull=False, assigned_object_type=vminterface_ct)[:2] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2689
What's Changed
Fix some more tests that were failing that weren't identified in the original factory fixture PRs
TODO