Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog difference displays "No changes" for old entries #2795

Closed
u1735067 opened this issue Nov 10, 2022 · 1 comment · Fixed by #2861
Closed

Changelog difference displays "No changes" for old entries #2795

u1735067 opened this issue Nov 10, 2022 · 1 comment · Fixed by #2861
Assignees
@gsnider2195
Labels
type: bug Something isn't working as expected

Comments

@u1735067
Copy link
Contributor

u1735067 commented Nov 10, 2022 •
edited
Loading

Environment

  • Nautobot version (Docker tag too if applicable): 1.4.7
  • Python version: 3.10
  • Database platform, version: pgsql
  • Middleware(s):

Steps to Reproduce

  1. Install an old (1.2.x) Nautobot version
  2. Change some objects
  3. Upgrade to the latest 1.4.x
  4. Check the objects changelogs

Expected Behavior

Changelog difference is displayed

Observed Behavior

Changelog difference displays "No changes" or displays only the new version (for changelog entries of existing objects created in the latest Nautobot version)

Additional informations

This seems to be caused by b44947c + fac90d2, where an new object_data_v2 is introduced (v1.3) and get_snapshots() (v1.4) uses this field at https://github.com/nautobot/nautobot/blob/v1.4.10/nautobot/extras/views.py#L1595 to display diff, without having fallback to object_data for older entries.
@u1735067 u1735067 changed the title Changelog displays "No changes" for old entries Changelog difference displays "No changes" for old entries Nov 10, 2022
@bryanculver bryanculver added the type: bug Something isn't working as expected label Nov 11, 2022
@gsnider2195 gsnider2195 self-assigned this Nov 15, 2022
@gsnider2195
Copy link
Contributor

Possibly related to #1830 #1530

@gsnider2195 gsnider2195 mentioned this issue Nov 16, 2022
Merged
5 tasks
This was referenced Feb 9, 2023
Open
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gsnider2195 gsnider2195

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix change log not displaying correctly when missing object_data_v2 field nautobot/nautobot
3 participants
@bryanculver @u1735067 @gsnider2195