Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Shadowed Fields on Existing Core Filter Sets #2806

Closed
Tracked by #1737
bryanculver opened this issue Nov 11, 2022 · 3 comments
Closed
Tracked by #1737

Change Shadowed Fields on Existing Core Filter Sets #2806

bryanculver opened this issue Nov 11, 2022 · 3 comments
Assignees
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@bryanculver
Copy link
Member

bryanculver commented Nov 11, 2022

Adapted from https://gist.github.com/jathanism/7c585954da4cb1a54997be31991cdaac#coreutilities --

Core/Utilities

Utilities are being included with core since nautobot.utilities.filters.BaseModelSet is the bread and butter here and we may very well end up folding all of the primitives from Utilities into Core to streamline the namespace.

Items that have been moved to their own story:

BaseFilterSet


Review:

https://gist.github.com/jathanism/7c585954da4cb1a54997be31991cdaac#extras

for fields to be changed under "Incorrect Fields"

NOTE: Let's do this after #2721 and #2722

@bryanculver
Copy link
Member Author

bryanculver commented Nov 11, 2022

Blocked by #2721 and #2722

@bryanculver bryanculver added status: blocked Another issue or external requirement is preventing implementation type: housekeeping Changes to the application which do not directly impact the end user impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release labels Nov 11, 2022
@bryanculver bryanculver added this to the v2.0.0 milestone Nov 11, 2022
@bryanculver bryanculver removed the status: blocked Another issue or external requirement is preventing implementation label Feb 1, 2023
@glennmatthews
Copy link
Contributor

glennmatthews commented Mar 20, 2023

Since we decided not to collapse extras into core for the time being, should this be split into two issues? I.e. create a separate issue for the extras filtersets?

@bryanculver
Copy link
Member Author

Done because bullet points were either already done or opened as separate issue, many of which are enhancements and not breaking changes.

💪

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants