Bug changing interface mode #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timizuoebideri1
commented
Nov 13, 2022
nautobot/dcim/forms.py
Outdated
Comment on lines
186
to
189
| mode = self.cleaned_data["mode"] | ||
|
|
||
| if mode != InterfaceModeChoices.MODE_TAGGED and tagged_vlans: | ||
| raise forms.ValidationError({"tagged_vlans": f"Clear tagged_vlans to set mode to {self.mode}"}) |
There was a problem hiding this comment.
Since tagged_vlans is auto cleared via Javascript whenever the mode is changed in UI, this is essentially redundant.
timizuoebideri1
requested review from
glennmatthews,
jathanism and
gsnider2195
gsnider2195
reviewed
Nov 14, 2022
|
After the changelog fragment is added it looks good to me. |
# Conflicts: # nautobot/dcim/api/serializers.py # nautobot/virtualization/api/serializers.py
gsnider2195
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #
What's Changed
Remove
tagged_vlanvalidation from the modelcleanmethod toFormandSerializerbecause we can't know if thetagged_valnhas been cleared or not. As a result, regardless of whether thetagged_valnhas been cleared or not via form or API, it raises an exception.Add validation to Form and serializer
TODO