Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role UI Tables, Views, Forms and URL #2885

Merged
merged 10 commits into from
Dec 15, 2022
Merged

Role UI Tables, Views, Forms and URL #2885

merged 10 commits into from
Dec 15, 2022

Conversation

timizuoebideri1
Copy link
Contributor

Closes: #1063

What's Changed

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@timizuoebideri1 timizuoebideri1 linked an issue Nov 20, 2022 that may be closed by this pull request
Add a generic Role model #1063
Closed
glennmatthews
glennmatthews reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to include testing as part of this PR or will that be a separate one?

nautobot/extras/forms/forms.py Outdated Show resolved Hide resolved
nautobot/extras/forms/forms.py Outdated Show resolved Hide resolved
nautobot/extras/forms/forms.py Outdated Show resolved Hide resolved
nautobot/extras/forms/forms.py Outdated Show resolved Hide resolved
nautobot/extras/navigation.py Outdated Show resolved Hide resolved
nautobot/extras/templates/extras/role.html Outdated Show resolved Hide resolved
nautobot/extras/views.py Outdated Show resolved Hide resolved
nautobot/extras/urls.py Outdated Show resolved Hide resolved
@timizuoebideri1 timizuoebideri1 mentioned this pull request Nov 25, 2022
Merged
15 tasks
@glennmatthews
Copy link
Contributor

@timizuoebideri1 do you plan to address the above feedback as a part of this PR?

@timizuoebideri1
Copy link
Contributor Author

timizuoebideri1 commented Dec 13, 2022 •
edited
Loading

@timizuoebideri1 do you plan to address the above feedback as a part of this PR?

🫤 I completely forgot to check this PR. I would resolve them here

@timizuoebideri1 timizuoebideri1 merged commit b1c3df3 into role-model-api Dec 15, 2022
@timizuoebideri1 timizuoebideri1 deleted the role-model-ui branch December 15, 2022 16:10
@bryanculver bryanculver mentioned this pull request Apr 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a generic Role model
2 participants
@timizuoebideri1 @glennmatthews