Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAM Overhaul: Refactor utilization/allocation calculation logic #2916

Closed
3 tasks
Tracked by #1032
lampwins opened this issue Nov 28, 2022 · 4 comments · Fixed by #3873
Closed
3 tasks
Tracked by #1032

IPAM Overhaul: Refactor utilization/allocation calculation logic #2916

lampwins opened this issue Nov 28, 2022 · 4 comments · Fixed by #3873
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@lampwins
Copy link
Member

lampwins commented Nov 28, 2022

This was referenced Nov 28, 2022
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Dec 5, 2022
@bryanculver bryanculver changed the title Refactor utilization/allocation calculation logic IPAM Overhaul: Refactor utilization/allocation calculation logic Mar 21, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Apr 19, 2023
@bryanculver
Copy link
Member

Need to do #2531 so solving this with that story (and IPAddress) while moving the existing code.

@gsnider2195 gsnider2195 self-assigned this Jun 6, 2023
@gsnider2195
Copy link
Contributor

gsnider2195 commented Jun 6, 2023

Action items from design meeting:

  • Prefix type network can only contain IP addresses and prefix pools
  • Prefix type container can only contain child prefixes
  • Prefix type is user serviceable and defaults to Container
  • Bring back the is_pool property
  • IP Address parent property cannot be set to a prefix with type pool, it will parent to the nearest network prefix
  • Prefix utilization should be split out into two columns, where calculations are based on the prefix type
    • Container shows utilization as sum of the size of direct child prefixes
    • Network shows utilization as sum of the number of direct child IPs and the size of any child pools
      • ⭐ Direct children of networks that are members of a pool are going to be counted twice
  • IPAddress and pool views should show ipaddress/pool relationships through net_contains lookups
  • Pools cannot contain child prefixes or ip addresses

This is going to require us to revisit the IPAM data migrations for prefix/ip address parenting

@gsnider2195
Copy link
Contributor

Adding a second utilization column slows down the list view even more (over 5 seconds to load 46 prefixes on my dev machine). I'm going to combine the columns for now.

@jathanism jathanism linked a pull request Jun 12, 2023 that will close this issue
7 tasks
@glennmatthews
Copy link
Contributor

Fixed by #3873.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants