Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device name to bulk interface rename header #3168

Merged
merged 12 commits into from Feb 9, 2023
Merged

Add device name to bulk interface rename header #3168

merged 12 commits into from Feb 9, 2023

Conversation

timizuoebideri1
Copy link
Contributor

Closes: #1380

What's Changed

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

glennmatthews
glennmatthews requested changes Jan 26, 2023
View reviewed changes
nautobot/dcim/templates/dcim/interface_bulk_rename.html Outdated Show resolved Hide resolved
nautobot/dcim/tests/test_views.py Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Jan 27, 2023
View reviewed changes
nautobot/dcim/views.py Outdated Show resolved Hide resolved
nautobot/utilities/testing/views.py Outdated Show resolved Hide resolved
nautobot/core/templates/generic/object_bulk_rename.html Outdated Show resolved Hide resolved
nautobot/core/views/generic.py Outdated Show resolved Hide resolved
timizuoebideri1 and others added 2 commits January 29, 2023 20:55
@timizuoebideri1 @glennmatthews
Update nautobot/core/templates/generic/object_bulk_rename.html
3597f9a 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@timizuoebideri1
GitHub review resolve
1741e39
HanlinMiao
HanlinMiao approved these changes Jan 31, 2023
View reviewed changes
nautobot/dcim/views.py Outdated Show resolved Hide resolved
nautobot/dcim/views.py Outdated Show resolved Hide resolved
HanlinMiao
HanlinMiao requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@HanlinMiao HanlinMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to select changes requested, sorry for the mess!

glennmatthews
glennmatthews reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing pylint but otherwise looks good!

@timizuoebideri1 timizuoebideri1 merged commit cce3fbf into develop Feb 9, 2023
@timizuoebideri1 timizuoebideri1 deleted the rename_header_on_interface branch February 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@HanlinMiao HanlinMiao HanlinMiao approved these changes

@jathanism jathanism Awaiting requested review from jathanism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the device name to the header (Rename interfaces)
3 participants
@timizuoebideri1 @glennmatthews @HanlinMiao