Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI 2.0: Create Build Pipeline for Core (Generates UI on startup/post-upgrade) #3203

Closed
3 tasks done
Tracked by #3142
bryanculver opened this issue Jan 31, 2023 · 1 comment · Fixed by #3306
Closed
3 tasks done
Tracked by #3142

UI 2.0: Create Build Pipeline for Core (Generates UI on startup/post-upgrade) #3203

bryanculver opened this issue Jan 31, 2023 · 1 comment · Fixed by #3306
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@bryanculver
Copy link
Member

bryanculver commented Jan 31, 2023

This translates as hiding npm behind a management command (e.g. nautobot-server build) and then having it as something that can then be called by other commands such as post_upgrade. (See similar example from NSoT project embedding this into setup.py build: https://github.com/dropbox/nsot/blob/develop/setup.py#L66-L90)

Webpack should be configured to deploy files to the STATICFILES_DIRS which defaults to project-static in the js directory? (See: https://pascalw.me/blog/2020/04/19/webpack-django.html):

  1. Have Webpack write to a directory in STATICFILES_DIRS
  2. Configure output.publicPath to match Django's STATIC_URL
  3. Don't let Webpack hash filenames (except for chunks, see below)
  4. Make sure webpack-dev-server writes files to disk (so Django can serve them in development)

Tasks

@bryanculver bryanculver changed the title Build Pipeline for Core (Generates UI on startup/post-upgrade) - 3 UI 2.0: Create Build Pipeline for Core (Generates UI on startup/post-upgrade) Jan 31, 2023
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jan 31, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Jan 31, 2023
@jathanism jathanism self-assigned this Feb 6, 2023
@bryanculver
Copy link
Member Author

Closed with #3306

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants