Removed CeleryTestCase and associated calling code.
#3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have `CELERY_TASK_ALWAYS_EAGER = True` in our test config, we no longer need this. Celery tasks/Jobs can be tested without the need for a single-threaded background worker so long as they are in a `TransactionTestCase`.
bryanculver
added
the
type: housekeeping
glennmatthews
approved these changes
Feb 6, 2023
| @@ -1903,9 +1903,8 @@ def test_regex_validation(self): | |||
| cf.delete() | |||
|
|
|||
|
|
|||
| class CustomFieldBackgroundTasks(CeleryTestCase): | |||
| class CustomFieldBackgroundTasks(TransactionTestCase): | |||
There was a problem hiding this comment.
I'm a bit curious about whether any of these test cases even need to be TransactionTestCases any more - any chance you looked into this?
There was a problem hiding this comment.
I did try that and they do require it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #DNE
What's Changed
Now that we have
CELERY_TASK_ALWAYS_EAGER = Truein our test config, we no longer need this. Celery tasks/Jobs can be tested without the need for a single-threaded background worker so long as they are in aTransactionTestCase.TODO