Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign IP to Multiple Interfaces: Prototype M2M Change #3236

Closed
Tracked by #2403
bryanculver opened this issue Feb 6, 2023 · 4 comments · Fixed by #3399
Closed
Tracked by #2403

Assign IP to Multiple Interfaces: Prototype M2M Change #3236

bryanculver opened this issue Feb 6, 2023 · 4 comments · Fixed by #3399
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone

Comments

@bryanculver
Copy link
Member

bryanculver commented Feb 6, 2023

Investigate how other aspects need to be changed/improved (potentially create some one-off stories for future follow-on in 2.0)

  • Primary IP on Device is a 1-to-1 enforcement, this likely can be derived
  • What additional fields should live on the through table
  • Primary IP of interface vs Primary IP of device

This should be the master issue and branch to go into next. Other subsequent PRs will target this (as it likely won't be mergable initially, forms and filters will be broken).

Since a spike of this nature will almost certainly be a "draw the rest of the owl" problem, it will build on #3190. It will help size the following story in #2403.

@bryanculver bryanculver changed the title Prototype M2M change and how other aspects need to be changed/improved (potentially create some one-off stories for future follow-on in 2.0) [target feature branch] - 3 Assign IP to Multiple Interfaces: Prototype M2M Change Feb 6, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Feb 6, 2023
@bryanculver bryanculver added the type: feature Introduction of new or enhanced functionality to the application label Feb 6, 2023
@gsnider2195 gsnider2195 self-assigned this Mar 2, 2023
@gsnider2195
Copy link
Contributor

gsnider2195 commented Mar 7, 2023

Through table fields

field type choices constraints/comments
source1 BooleanField True/False
destination1 BooleanField True/False
default2 BooleanField True/False
preferred2 BooleanField True/False
primary2 BooleanField True/False
secondary3 BooleanField True/False
standby4 BooleanField True/False Probably covered by InterfaceRedundancyGroup(#2621)?
primary_for_device BooleanField True/False Limited to one per address family per device

Footnotes

  1. Cisco tunnel configuration 2

  2. JunOS interface configuration 2 3

  3. Cisco IOS configuration

  4. Cisco ASA configuration

@lampwins
Copy link
Member

lampwins commented Mar 7, 2023

One point of clarification on primary IP, it needs to be zero or one of each family type (v4, and v6) per device. I.e. a device may have both a primary v4 and v6 address at the same time.

@gsnider2195
Copy link
Contributor

One point of clarification on primary IP, it needs to be zero or one of each family type (v4, and v6) per device. I.e. a device may have both a primary v4 and v6 address at the same time.

Thanks for the reminder. I probably would have forgotten to account for different address families!

@bryanculver
Copy link
Member Author

Completed with #3399

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants