Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Groups: Improve Reversibility Performance #3269

Open
Tracked by #3268
bryanculver opened this issue Feb 8, 2023 · 0 comments · Fixed by #4092
Open
Tracked by #3268

Dynamic Groups: Improve Reversibility Performance #3269

bryanculver opened this issue Feb 8, 2023 · 0 comments · Fixed by #4092
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@bryanculver
Copy link
Member

bryanculver commented Feb 8, 2023

Improve reversibility performance via caching (Django's built-in, not CacheOps). Either on the membership instances themselves or the groups. The goal is to cut down reverse lookup time to something reasonable for the user. As an example with current performance, 10k Devices with 10 Dynamic Groups can cause the Device Dynamic Group Detail view (Devices > Device > Dynamic Groups) can sometimes fail to load.

User (likely developers) should be able to choose if they can use the cached lists or need to skip the cache for 100% accuracy.

Cache should have reasonable expiration behavior as well as refreshed with basic operations (modifications of the Dynamic Group's filter definition).


Other ideas have been moved up to #3268

@bryanculver bryanculver changed the title Improve Reversibility (currently lazy/slow) Dynamic Groups: Improve Reversibility (currently lazy/slow) Feb 8, 2023
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Feb 8, 2023
@bryanculver bryanculver linked a pull request Jul 31, 2023 that will close this issue
@bryanculver bryanculver changed the title Dynamic Groups: Improve Reversibility (currently lazy/slow) Dynamic Groups: Improve Reversibility Performance Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Status: To Groom
Development

Successfully merging a pull request may close this issue.

1 participant