DynamicGroups filter data migration from Site/Region to Location #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Looks valid to me.
This makes me think that it would be a good feature for us to introduce something like a nautobot-server audit_dynamic_groups command which would iterate over all DGs and make sure their filters are valid. Because we're not currently fixing up DGs to account for all of the other filtering changes that we're making in 2.0...
Comment on lines
245
to
250
| if "location" not in dg.filter.keys(): | ||
| dg.filter["location"] = [] | ||
| dg.filter["location"] += dg.filter.get("region", []) | ||
| dg.filter.pop("region", None) | ||
| if not dg.filter["location"]: # Remove the location key if the list is empty | ||
| dg.filter.pop("location") |
There was a problem hiding this comment.
Maybe?
if "region" in dg.filter:
dg.filter.setdefault("location", []).extend(dg.filter.pop("region"))
Comment on lines
247
to
248
| if not dg.filter["location"]: # Remove the location key if the list is empty | ||
| dg.filter.pop("location") |
There was a problem hiding this comment.
Should these two lines be removed? Same question below.
There was a problem hiding this comment.
Right right they should, I was thinking that "location" key might be an empty list, but we are already checking the "region" key to ensure the list wont be empty. Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #
What's Changed
TODO