Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branching Naming Conventions #3314

Closed
bryanculver opened this issue Feb 14, 2023 · 7 comments · Fixed by #3323
Closed

Branching Naming Conventions #3314

bryanculver opened this issue Feb 14, 2023 · 7 comments · Fixed by #3323
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@bryanculver
Copy link
Member

bryanculver commented Feb 14, 2023

Proposed Changes

Establish a branch naming convention, something like:

Where 0000 is the Github issue number.

Justification

Finding high-interest branches (main,develop,next) can be hard since alpha sorted they are mixed between issue-number leading branch names or users who's names are before the letter N.

@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Feb 14, 2023
@gsnider2195
Copy link
Contributor

I'd like to nominate u/[un/initials]-0000-branch-summary for an optional branch name

@bryanculver
Copy link
Member Author

Whatever we accept here I would update the pre-commit hook (https://github.com/nautobot/nautobot/blob/develop/scripts/git-hooks/pre-commit) to ensure you commit to a user-leading branch name (taking in consideration @gsnider2195's comment above).

@cmsirbu
Copy link
Contributor

cmsirbu commented Feb 15, 2023

I'm not sure there's a need for numbers in the branch name - unless they are tied to an issue or some other reference?

@jathanism
Copy link
Contributor

I'm not sure there's a need for numbers in the branch name - unless they are tied to an issue or some other reference?

Some people tend to put the issue number in the branch name. It's optional.

@bryanculver
Copy link
Member Author

I'm not sure there's a need for numbers in the branch name - unless they are tied to an issue or some other reference?

Some people tend to put the issue number in the branch name. It's optional.

I am proposing making it required.

@bryanculver
Copy link
Member Author

I'm not sure there's a need for numbers in the branch name - unless they are tied to an issue or some other reference?

They are intended to map to the issue number in Github. It should be an exception to not have them.

@jathanism
Copy link
Contributor

I am proposing making it required.

🤐

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants