ObjectPermission Data Migration from Region/Site to Location #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnider2195
reviewed
Mar 14, 2023
| @@ -299,6 +299,7 @@ def reassign_model_instances_to_locations(apps, model): | |||
| Location = apps.get_model("dcim", "location") | |||
| LocationType = apps.get_model("dcim", "locationtype") | |||
| location_ct = ContentType.objects.get_for_model(Location) | |||
| location_type_ct = ContentType.objects.get_for_model(LocationType) | |||
| model_class = apps.get_model("dcim", f"{model}") | |||
There was a problem hiding this comment.
nitpick inc
Suggested change
| model_class = apps.get_model("dcim", f"{model}") | |
| model_class = apps.get_model("dcim", model) |
gsnider2195
reviewed
Mar 14, 2023
| region_permissions = self.object_permission.objects.filter( | ||
| name__in=["Test Region Permission 1", "Test Region Permission 2"] | ||
| ) | ||
| self.assertEqual( |
There was a problem hiding this comment.
You could make this more concise by using assertCountEqual and dropping sorted. Not blocking
There was a problem hiding this comment.
Yeah, I do want to check the actual content of the many-to-many field just to make sure it is correct.
There was a problem hiding this comment.
assertCountEqual does check that the content of the iterables matches it just ignores the sort order. I don't know why they named it assertCountEqual
gsnider2195
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #
What's Changed
Location/LocationTypeContentTypetoobject_typesfield of existingRegionandSiteObjectPermissionsTODO