Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Relationship.slug to Relationship.key #3449

Closed
HanlinMiao opened this issue Mar 17, 2023 · 1 comment · Fixed by #3720
Closed

Rename Relationship.slug to Relationship.key #3449

HanlinMiao opened this issue Mar 17, 2023 · 1 comment · Fixed by #3720
Assignees
@HanlinMiao
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@HanlinMiao
Copy link
Contributor

HanlinMiao commented Mar 17, 2023 •
edited

Proposed Changes

Rename slug field on Relationship Model to key.

Justification

slug -> key makes the distinction between model fields for internal use/external use.

TODO

Checkout #3426
@HanlinMiao HanlinMiao added this to the v2.0.0 milestone Mar 17, 2023
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Mar 20, 2023
@HanlinMiao HanlinMiao self-assigned this May 8, 2023
@HanlinMiao HanlinMiao mentioned this issue May 9, 2023
Merged
7 tasks
@HanlinMiao
Copy link
Contributor Author

Closed with #3720

@HanlinMiao HanlinMiao mentioned this issue May 10, 2023
Merged
7 tasks
@HanlinMiao HanlinMiao linked a pull request May 18, 2023 that will close this issue
Renamed Relationship model attribute slug to key. Renamed Relationship model attribute name to label. #3720
Merged
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HanlinMiao HanlinMiao

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
2 participants
@bryanculver @HanlinMiao