Fix advance filter error on multiple custom filter #3574
Conversation
There was a problem hiding this comment.
Also, this seems to only address the MultiSelect symptom reported in #3391. What about fixing the Select symptom as well?
on custom field of the type selection
Only one entry can be selected.
|
|
||
| if not required or default_choice is None: | ||
| choices = add_blank_choice(choices) | ||
|
|
||
| # Set the initial value to the first available choice (if any) | ||
| if set_initial and default_choice: | ||
| initial = default_choice.value | ||
|
|
||
| if self.type == CustomFieldTypeChoices.TYPE_SELECT: | ||
| if not required or default_choice is None: | ||
| choices = add_blank_choice(choices) | ||
| field_class = CSVChoiceField if for_csv_import else forms.ChoiceField |
There was a problem hiding this comment.
This change feels wrong to me - the form field (as opposed to the filter form field) for both Select and MultiSelect custom fields should have a blank choice, shouldn't it? Can you help me understand why this should be specific to Select fields only?
There was a problem hiding this comment.
By default multi select fields have blanks
There was a problem hiding this comment.
Adding it makes blank a choice in the multi select, which was causing error
| @@ -70,7 +70,7 @@ class CustomFieldJSONFilter(CustomFieldFilterMixin, django_filters.Filter): | |||
| """Custom field single value filter for backwards compatibility""" | |||
|
|
|||
|
|
|||
| class CustomFieldMultiSelectFilter(CustomFieldFilterMixin, django_filters.Filter): | |||
| class CustomFieldMultiSelectFilter(CustomFieldFilterMixin, django_filters.MultipleChoiceFilter): | |||
| """Custom field single value filter for backwards compatibility""" | |||
There was a problem hiding this comment.
Is the docstring here no longer accurate/relevant? Do we in fact need this to remain a non-multiple-choice filter for some compatibility reason?
There was a problem hiding this comment.
as of now i get this error, Im thinking its a bug
timizuoebideri1
force-pushed
the
u/timizuoebideri1-3391-cf-multiple_advance_filter
branch
from
040edaf
to
8738527
Compare
…mizuoebideri1-3391-cf-multiple_advance_filter
…ttps://github.com/nautobot/nautobot into u/timizuoebideri1-3391-cf-multiple_advance_filter
timizuoebideri1
deleted the
u/timizuoebideri1-3391-cf-multiple_advance_filter
branch
Closes: #3391
What's Changed
Error reported was caused by
is_single_choice_fieldreturningTrueforCustomFieldMultiSelectFilterbecauseCustomFieldMultiSelectFilterinherits fromdjango_filters.Filterand notdjango_filters.MultipleChoiceFilter.Also fixed an additional bug where the page freeze after selecting a custom multiple field choice.
TODO