Ignore upcoming UI non-source files #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nautobot/ui/.gitignore
Outdated
There was a problem hiding this comment.
Would it make any sense to (in develop only) add the entire nautobot/ui directory to the global .gitignore?
| @@ -29,3 +29,5 @@ htmlcov/* | |||
| /nautobot/project-static/docs/ | |||
| /examples/example_plugin/example_plugin/static/example_plugin/docs/ | |||
| development/factory_dump.json | |||
| node_modules | |||
| nautobot/ui | |||
There was a problem hiding this comment.
We'll just need to be careful when next we merge up into next that this doesn't get carried over by accident. :-) I guess your previous approach was "safer" in that regard? 🤷
There was a problem hiding this comment.
That was my thinking but I plan to merge develop into next shortly anyway so I’ll remove it there.
glennmatthews
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #DNE
What's Changed
Make it easier to work with the upcoming UI: don't let untracked file suddenly become tracked.
TODO