Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Docker compose invoke commands clean up after themselves #3621

Merged
merged 2 commits into from Apr 19, 2023
Merged

Have Docker compose invoke commands clean up after themselves #3621

merged 2 commits into from Apr 19, 2023

Conversation

bryanculver
Copy link
Member

Closes: #3621

What's Changed

No more of this:

Screenshot 2023-04-19 at 17 09 50

Screenshot 2023-04-19 at 17 09 28

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • [NA] Unit, Integration Tests
  • [NA] Documentation Updates (when adding/changing features)
  • [NA] Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@bryanculver bryanculver requested a review from a team April 19, 2023 21:17
@bryanculver bryanculver changed the title Closed #3621: Have Docker compose invoke commands clean up after themselves Have Docker compose invoke commands clean up after themselves Apr 19, 2023
glennmatthews
glennmatthews approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

changes/3621.changed Outdated Show resolved Hide resolved
@bryanculver @glennmatthews
Update changes/3621.changed
0a6bbef 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@bryanculver bryanculver merged commit 085618e into develop Apr 19, 2023
17 checks passed
@bryanculver bryanculver deleted the u/bryanculver-3621-docker-compose-remove-after-run branch April 19, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryanculver @glennmatthews