Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix job edit form silently failing #3675

Merged
merged 4 commits into from
May 4, 2023
Merged

fix job edit form silently failing #3675

merged 4 commits into from
May 4, 2023

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented May 1, 2023

Closes: DNE

What's Changed

The slug field was removed from the form template but not the form, so when editing a job the form would always fail because it expected a slug that cannot be provided.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@glennmatthews
Copy link
Contributor

The Job model still has a slug field - should the correct fix be to add the form field back to the template, instead of removing it from the form?

@glennmatthews
Copy link
Contributor

Is this the reason why UT is failing in next-ui as well?

@gsnider2195
Copy link
Contributor Author

The Job model still has a slug field - should the correct fix be to add the form field back to the template, instead of removing it from the form?

I think so. We'll eventually be able to remove the slug field on Job but since it's still there I agree that the appropriate fix is to re-add the field to the html template.

Is this the reason why UT is failing in next-ui as well?

It is. I made this change on that branch so that we could enable/run jobs to populate the job results table on the new home page. I'll fix it over there too.

@gsnider2195 gsnider2195 merged commit 5108c45 into next May 4, 2023
@gsnider2195 gsnider2195 deleted the u/gas-jobs-edit-form branch May 4, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants