Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jobs Overhaul: Update JobResult manager store_result method to censor sensitive variables #3692

Closed
Tracked by #765
bryanculver opened this issue May 3, 2023 · 3 comments · Fixed by #3800
Closed
Tracked by #765

Jobs Overhaul: Update JobResult manager store_result method to censor sensitive variables #3692

bryanculver opened this issue May 3, 2023 · 3 comments · Fixed by #3800
Assignees
@HanlinMiao
Labels
type: bug Something isn't working as expected
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

bryanculver commented May 3, 2023 •
edited
Loading

For 2.0.0: Just blank the variable inputs if job is marked as having sensitive variables.
@bryanculver bryanculver mentioned this issue May 3, 2023
Closed
9 tasks
@bryanculver bryanculver added the type: bug Something isn't working as expected label May 3, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone May 3, 2023
@bryanculver bryanculver changed the title Update JobResult manager store_result method to censor sensitive variables Jobs Overhaul: Update JobResult manager store_result method to censor sensitive variables May 3, 2023
@gsnider2195
Copy link
Contributor

blocked by #3713

@bryanculver
Copy link
Member Author

If not already captured somewhere else: field-level sensitive variables.

@HanlinMiao HanlinMiao self-assigned this May 23, 2023
@HanlinMiao HanlinMiao mentioned this issue May 23, 2023
Merged
7 tasks
@HanlinMiao HanlinMiao linked a pull request May 23, 2023 that will close this issue
Update JobResult manager store_result method to censor sensitive vari… #3800
Merged
7 tasks
@HanlinMiao
Copy link
Contributor

Closed by #3800

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HanlinMiao HanlinMiao

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Update JobResult manager store_result method to censor sensitive vari… nautobot/nautobot
3 participants
@bryanculver @HanlinMiao @gsnider2195