Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in Relationship Model Migration #3729

Merged
merged 9 commits into from
May 10, 2023
Merged

Fixed bug in Relationship Model Migration #3729

merged 9 commits into from
May 10, 2023

Conversation

HanlinMiao
Copy link
Contributor

@HanlinMiao HanlinMiao commented May 10, 2023 •
edited
Loading

Closes: N/A

What's Changed

The relationship model does not have the name attribute anymore at the point of that migration. It should be label.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

bryanculver
bryanculver approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@bryanculver bryanculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HanlinMiao please :yeet: a changelog fragment in and get this merged 👍

@bryanculver bryanculver merged commit 45424c6 into next May 10, 2023
16 of 18 checks passed
@bryanculver bryanculver deleted the hanlin-#3449 branch May 10, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HanlinMiao @bryanculver @glennmatthews