Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken --cache_test_fixtures when running tests #3737

Merged
merged 3 commits into from
May 12, 2023
Merged

Fix broken --cache_test_fixtures when running tests #3737

merged 3 commits into from
May 12, 2023

Conversation

gsnider2195
Copy link
Contributor

Closes: #DNE

What's Changed

This just disables the --natural_primary and --natural_foreign arguments on dumpdata. Since this is used for testing with a freshly flushed database this shouldn't be a problem?

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

glennmatthews
glennmatthews approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for now!

@gsnider2195 gsnider2195 merged commit fdf1cb1 into next May 12, 2023
19 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-fix-test-fixture-cache branch May 12, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathanism jathanism jathanism approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gsnider2195 @jathanism @glennmatthews