Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Service Uniqueness Constraint #3845

Closed
bryanculver opened this issue Jun 3, 2023 · 1 comment · Fixed by #3863
Closed

Change Service Uniqueness Constraint #3845

bryanculver opened this issue Jun 3, 2023 · 1 comment · Fixed by #3863
Assignees
@HanlinMiao
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

Carved out of #2908

Proposed Changes

Unique together: (device, name) and (vm, name) with natural key (name, device, vm); for duplication use other fields to help add to name uniqueness
@bryanculver bryanculver added type: housekeeping Changes to the application which do not directly impact the end user impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release labels Jun 3, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Jun 3, 2023
@bryanculver bryanculver mentioned this issue Jun 3, 2023
Closed
@HanlinMiao HanlinMiao self-assigned this Jun 6, 2023
@HanlinMiao HanlinMiao mentioned this issue Jun 6, 2023
Merged
7 tasks
@HanlinMiao HanlinMiao linked a pull request Jun 6, 2023 that will close this issue
Added two uniqueness constraints, ("name", "device") and ("name", "virtual_machine"), to Service model. #3863
Merged
7 tasks
@HanlinMiao
Copy link
Contributor

Closed by #3863

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HanlinMiao HanlinMiao

Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
2 participants
@bryanculver @HanlinMiao